chore: Run PHPUnit tests on Mysql and Pgsql #7680
Open
+94
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
fix/mbstring
branch
from
241f456 to
25649a4
Compare
VincentLanglet
force-pushed
the
fix/mbstring
branch
4 times, most recently
from
fee7617 to
87a8329
Compare
VincentLanglet
force-pushed
the
fix/mbstring
branch
from
87a8329 to
6a74b86
Compare
VincentLanglet
changed the title
VincentLanglet
force-pushed
the
fix/mbstring
branch
from
d02401d to
dd02dd9
Compare
VincentLanglet
force-pushed
the
fix/mbstring
branch
from
dd02dd9 to
ddd54ee
Compare
VincentLanglet
commented
Jan 17, 2026
| } | ||
|
|
||
| public ?int $totalQuantity; | ||
| public int|string|null $totalQuantity; |
Contributor
Author
There was a problem hiding this comment.
Depends on the DB it's an int or a string
| filter: new OrderFilter(), | ||
| property: 'createdAt', | ||
| filterContext: OrderFilterInterface::NULLS_ALWAYS_FIRST, | ||
| filterContext: ['nulls_comparison' => OrderFilterInterface::NULLS_ALWAYS_FIRST], |
Contributor
Author
There was a problem hiding this comment.
It wasn't correctly configured/tested ; I updated it.
| filter: new OrderFilter(), | ||
| property: 'createdAt', | ||
| filterContext: OrderFilterInterface::NULLS_ALWAYS_FIRST, | ||
| filterContext: ['nulls_comparison' => OrderFilterInterface::NULLS_ALWAYS_FIRST], |
Contributor
Author
There was a problem hiding this comment.
NB: this was "tested" but in reality this is not implemented in ODM
|
|
||
| #[Assert\Range(min: 1, max: 10)] | ||
| #[ORM\Column] | ||
| #[ORM\Column(name: '_range')] |
Contributor
Author
There was a problem hiding this comment.
range is a reserved property in Mysql/Postgres
VincentLanglet
force-pushed
the
fix/mbstring
branch
from
c304f3b to
2e30b2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @soyuka ; since I'm playing with some driver-depends features like
I think we need running PHPUnit with Mysql/Pgsql too and not only Sqlite @soyuka