Skip to content

Conversation

@skalthoff
Copy link
Collaborator

@skalthoff skalthoff commented Dec 8, 2025

What is the change

Changes the MultipleArtistsSheet modal presentation style from formSheet to containedModal within the Player stack navigator, and adds a clarifying comment for single-artist navigation.

Specific changes:

  • src/screens/Player/index.tsx: Replaced formSheet presentation (with sheetAllowedDetents and sheetGrabberVisible) with containedModal
  • src/components/Player/components/song-info.tsx: Added documentation comment explaining React Navigation's push behavior

What does this address

Fixes a crash that occurred when tapping an artist name in the Player's song info area when a track has multiple artists. The crash was caused by attempting to present a formSheet modal while already inside the Player modal - iOS doesn't allow stacking sheet-style modals in this way. Using containedModal instead keeps the artist selection sheet within the Player's navigation context, preventing the crash.

Issue number / link

N/A (crash discovered during manual testing)

Tag reviewers

@anultravioletaurora

@skalthoff
Copy link
Collaborator Author

@copilot wtf even is this pr?

Copy link

Copilot AI commented Jan 6, 2026

@skalthoff I've opened a new pull request, #902, to work on those changes. Once the pull request is ready, I'll request review from you.

@skalthoff
Copy link
Collaborator Author

fecking useless jfc

@skalthoff skalthoff changed the title refactor: update MultipleArtistsSheet modal presentation to containedModal and clarify artist navigation. fix: prevent crash when selecting artist from Player modal Jan 7, 2026
@skalthoff
Copy link
Collaborator Author

ok this is actually useful and hsould be merged unless you have any comments @anultravioletaurora

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants