fix: prevent crash when selecting artist from Player modal #800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change
Changes the
MultipleArtistsSheetmodal presentation style fromformSheettocontainedModalwithin the Player stack navigator, and adds a clarifying comment for single-artist navigation.Specific changes:
src/screens/Player/index.tsx: ReplacedformSheetpresentation (withsheetAllowedDetentsandsheetGrabberVisible) withcontainedModalsrc/components/Player/components/song-info.tsx: Added documentation comment explaining React Navigation's push behaviorWhat does this address
Fixes a crash that occurred when tapping an artist name in the Player's song info area when a track has multiple artists. The crash was caused by attempting to present a
formSheetmodal while already inside the Player modal - iOS doesn't allow stacking sheet-style modals in this way. UsingcontainedModalinstead keeps the artist selection sheet within the Player's navigation context, preventing the crash.Issue number / link
N/A (crash discovered during manual testing)
Tag reviewers
@anultravioletaurora