Skip to content

Conversation

@ardenspace
Copy link

@ardenspace ardenspace commented Jan 10, 2026

Description

Fixes build error caused by missing autofillHints parameter in AFTextField widget definition. The parameter was being used in password fields but wasn't defined in the widget, causing compilation errors.

Changes

  • Added autofillHints parameter to AFTextField constructor
  • Added field declaration: final Iterable<String>? autofillHints;
  • Passed autofillHints to the internal TextField widget

Results

image

Fixes

fixes #8425


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Bug Fixes:

  • Fix compilation error by defining and wiring through the autofillHints parameter used by AFTextField consumers.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 10, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds an optional autofillHints parameter to AFTextField and forwards it to the underlying TextField to fix a build error when autofillHints is used by callers.

Class diagram for updated AFTextField autofillHints support

classDiagram
  class AFTextField {
    +int? maxLength
    +Iterable<String>? autofillHints
    +AFTextField(Key? key, FocusNode? focusNode, bool readOnly, int? maxLength, Iterable<String>? autofillHints)
  }

  class AFTextFieldState {
  }

  class _AFTextFieldState {
    +build(BuildContext context) TextField
  }

  class TextField {
  }

  AFTextFieldState <|-- _AFTextFieldState
  AFTextField "1" *-- "1" _AFTextFieldState
  _AFTextFieldState --> TextField
  AFTextField --> AFTextFieldState
Loading

File-Level Changes

Change Details Files
Extend AFTextField to accept an optional autofillHints parameter and forward it to the internal TextField.
  • Add autofillHints named parameter to AFTextField constructor with nullable Iterable type
  • Declare final Iterable? autofillHints field with documentation comment on AFTextField
  • Pass widget.autofillHints through to the underlying TextField's autofillHints property in the build method
frontend/appflowy_flutter/packages/appflowy_ui/lib/src/component/textfield/textfield.dart

Assessment against linked issues

Issue Objective Addressed Explanation
#8425 Update AFTextField to accept an autofillHints parameter and forward it to the internal TextField so that usages with autofillHints compile successfully.
#8425 Resolve the build failure caused by the missing autofillHints named parameter in AFTextField, allowing the project to build successfully on the main branch.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Build failure: Error: No named parameter with the name 'autofillHints'.

2 participants