-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix: Add missing autofillHints param to AFTextField to fix build error #8426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ardenspace
wants to merge
1
commit into
AppFlowy-IO:main
Choose a base branch
from
ardenspace:fix/aftextfield-build-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: Add missing autofillHints param to AFTextField to fix build error #8426
ardenspace
wants to merge
1
commit into
AppFlowy-IO:main
from
ardenspace:fix/aftextfield-build-error
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds an optional autofillHints parameter to AFTextField and forwards it to the underlying TextField to fix a build error when autofillHints is used by callers. Class diagram for updated AFTextField autofillHints supportclassDiagram
class AFTextField {
+int? maxLength
+Iterable<String>? autofillHints
+AFTextField(Key? key, FocusNode? focusNode, bool readOnly, int? maxLength, Iterable<String>? autofillHints)
}
class AFTextFieldState {
}
class _AFTextFieldState {
+build(BuildContext context) TextField
}
class TextField {
}
AFTextFieldState <|-- _AFTextFieldState
AFTextField "1" *-- "1" _AFTextFieldState
_AFTextFieldState --> TextField
AFTextField --> AFTextFieldState
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99f8d97 to
5ce1b8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes build error caused by missing
autofillHintsparameter inAFTextFieldwidget definition. The parameter was being used in password fields but wasn't defined in the widget, causing compilation errors.Changes
autofillHintsparameter toAFTextFieldconstructorfinal Iterable<String>? autofillHints;autofillHintsto the internalTextFieldwidgetResults
Fixes
fixes #8425
PR Checklist
Summary by Sourcery
Bug Fixes: